feat(types): allow readonly array in omit function
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
requested changes
Oct 18, 2024
tests/object/omit.test.ts
Outdated
| expect(result).toEqual({ | ||
| age: 20, | ||
| active: true, | ||
| }) | ||
| }) | ||
| test('returns object without omitted properties when keys are readonly', () => { |
There was a problem hiding this comment.
We don't need a runtime test here, since this PR only affects type-checking.
We could add a ”type test”, but this change is simple enough that I think that too would be overkill.
There was a problem hiding this comment.
Hey @aleclarson If it's an overkill then I think it's better to remove this test. It's a simple change.
There was a problem hiding this comment.
I will remove it.
aleclarson
changed the title
omit function
|
🎉 This will be released in v12.2.0 (and a beta before then, once I fix the CI script) |
MarlonPassos-git
pushed a commit
to MarlonPassos-git/radashi
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
This pull request is an enhancement to the omit function, allowing it to accept
readonlyarray keys. This means that the keys array cannot be modified within the functionRelated issue, if any:
#267
For any code change,
Does this PR introduce a breaking change?
No