Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(series): avoid object spread in loop #37

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

cdreeves
Copy link
Contributor

Tip

The owner of this PR can publish a preview release by commenting /publish in this PR. Afterwards, anyone can try it out by running pnpm add radashi@pr<PR_NUMBER>.

Description

Avoid the extra objects being created

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

@aleclarson aleclarson added the 🔥 performance An improvement to runtime performance label Jun 28, 2024
@aleclarson aleclarson changed the title improve series perf perf(series): avoid object spread in loop Jun 29, 2024
@aleclarson aleclarson disabled auto-merge June 30, 2024 00:15
@aleclarson aleclarson merged commit d3b6331 into radashi-org:main Jun 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 performance An improvement to runtime performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants