Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use writefile with getbufline in JobExit #4

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 24, 2016

This is more sane (removes three silented commands!) and fixes an issue,
where this would fail ("Not allowed here") in case a hit-enter prompt
was displayed by vim-dispatch [1].

This would then cause the JobExit function to abort and not handle the
output/closing at all.

1: https://github.com/tpope/vim-dispatch/blob/eb3e564fb1edfee09fe6aeb57f3388e273da72c8/autoload/dispatch.vim#L218-L219

This is more sane (removes three silented commands!) and fixes an issue,
where this would fail ("Not allowed here") in case a hit-enter prompt
was displayed by vim-dispatch [1].

This would then cause the JobExit function to abort and not handle the
output/closing at all.

1: https://github.com/tpope/vim-dispatch/blob/eb3e564fb1edfee09fe6aeb57f3388e273da72c8/autoload/dispatch.vim#L218-L219
@radenling
Copy link
Owner

Less code and fixes a bug, thanks!

@blueyed blueyed deleted the use-writefile-in-JobExit branch March 25, 2016 13:11
@blueyed
Copy link
Contributor Author

blueyed commented Mar 25, 2016

Yeah! :)

There's still another issue in this regard (when the hit-enter prompt is caused by vim-dispatch).
Maybe you can help with that? tpope/vim-dispatch#166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants