Improve completion in region #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemera
force-pushed
the
improve-completion-in-region
branch
from
679facb to
f19e2d3
Compare
clemera
force-pushed
the
improve-completion-in-region
branch
from
f19e2d3 to
a58cc18
Compare
|
Why has your opinion on this changed? The behavior of single candidate lists. I guess it makes sense to do this, but consistency is also good. |
|
It is actually more consistent now in a way because we have the same behaviour for non file completions. |
|
I'm still figuring out if we can redrop into minibuffer completion when you press TAB again in the single candidate case, then it would be perfect. |
|
Should work fine now. I also added the option asked for in #223. |
|
@clemera Cool! |
clemera
force-pushed
the
improve-completion-in-region
branch
from
8bee6f4 to
62ffaa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #260. This will insert the path immediately if there is only one match and also ensures the syntax table is set correctly for all file completions. I also adjusted the exit-status to
soleas this leads to the least surprising behaviour (no insertion of spaces after file completion which also does not happen with default completion). The exit status is very much tied to the way default completion works andsoleseems to make the most sense with selectrum when it is not clearlyfinished. I also decided to push the mark at the start of the candidate so one can easily jump back to the beginning of the completion.