-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update annotation and affixation handling #289
Update annotation and affixation handling #289
Conversation
Could you document your findings somewhere please? This would help for marginalia! |
Okay, I will explain things in the docstring of the function. |
e5070a5
to
749f4c2
Compare
749f4c2
to
64c95b4
Compare
5edaa35
to
d35e9c4
Compare
@clemera I pushed preliminary support for affixation function to marginalia. The affixation function is just a simple wrapper around the annotation function for now, see minad/marginalia@ef4fabf. I wonder about the docstring of selectrum--affixate, it sounds as if you can manipulate the candidate itself? This is not the case right? |
Nice!
I think for display purposes affixation does allow that. |
And then it adds a 'display over the candidate or how is this supposed to work? How did you implement it in selectrum? |
I think they take the strings as returned by the affixation use them for insertion into the completion buffer. In selectrum I use them for display as they are returned, too. For Selectrum the candidate index is used to retrieve the actual candidate so it doesn't matter how it is displayed, not sure how they handle it for default completion. |
Makes sense, thanks! |
See #286, allow for more complex affixation items and refactor annotation code.