Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotation and affixation handling #289

Merged

Conversation

clemera
Copy link
Collaborator

@clemera clemera commented Dec 17, 2020

See #286, allow for more complex affixation items and refactor annotation code.

@minad
Copy link
Contributor

minad commented Dec 17, 2020

Could you document your findings somewhere please? This would help for marginalia!

@clemera
Copy link
Collaborator Author

clemera commented Dec 17, 2020

Okay, I will explain things in the docstring of the function.

@clemera clemera force-pushed the allow-more-complex-affixation-items branch 2 times, most recently from e5070a5 to 749f4c2 Compare December 17, 2020 17:36
@clemera clemera force-pushed the allow-more-complex-affixation-items branch from 749f4c2 to 64c95b4 Compare December 17, 2020 19:19
@clemera clemera force-pushed the allow-more-complex-affixation-items branch from 5edaa35 to d35e9c4 Compare December 17, 2020 20:03
@clemera clemera changed the title Allow more complex affixation items Update annotation and affixation handling Dec 17, 2020
@clemera clemera merged commit 11513bd into radian-software:master Dec 17, 2020
@minad
Copy link
Contributor

minad commented Dec 19, 2020

@clemera I pushed preliminary support for affixation function to marginalia. The affixation function is just a simple wrapper around the annotation function for now, see minad/marginalia@ef4fabf. I wonder about the docstring of selectrum--affixate, it sounds as if you can manipulate the candidate itself? This is not the case right?

@clemera
Copy link
Collaborator Author

clemera commented Dec 19, 2020

Nice!

I wonder about the docstring of selectrum--affixate, it sounds as if you can manipulate the candidate itself? This is not the case right?

I think for display purposes affixation does allow that.

@minad
Copy link
Contributor

minad commented Dec 19, 2020

And then it adds a 'display over the candidate or how is this supposed to work? How did you implement it in selectrum?

@clemera
Copy link
Collaborator Author

clemera commented Dec 19, 2020

I think they take the strings as returned by the affixation use them for insertion into the completion buffer. In selectrum I use them for display as they are returned, too. For Selectrum the candidate index is used to retrieve the actual candidate so it doesn't matter how it is displayed, not sure how they handle it for default completion.

@minad
Copy link
Contributor

minad commented Dec 19, 2020

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants