Compute table candidates with last buffer current #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #75 and #312
describe-variable
was slowed down with Selectrum because the predicate switches back to the last buffer for each candidate. By computing the candidates with the last buffer current by default we avoid the slow down for such cases. The docs don't mention any assumptions about the current buffer for the table/predicate, Ivy does run the computation before the minibuffer is even entered so it doesn't has this problem, we keep computing them late to allow for exampleselectrum-set-selected-candidate
to skip the initial computation which is used byembark
for example.