Improve default handling for file completions #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemera
changed the title
clemera
force-pushed
the
accept-default-list-for-file-completions
branch
2 times, most recently
from
e68110b to
f81b2a9
Compare
clemera
force-pushed
the
accept-default-list-for-file-completions
branch
from
f81b2a9 to
2cbde8a
Compare
clemera
changed the title
raxod502
added a commit
that referenced
this pull request
Feb 26, 2021
raxod502
added a commit
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectrum-read-file-namewould error when passing a list fordefault-filenameas reported by @VojtechStep in #401 . Also we still had code which would remove the final slash for sorting the default first in file completions which wouldn't apply any more as dir candidates don't use an overlay any more to display the slash but contain it in their string now.I also improved the sorting so "/home/user/default" and "~/default" or a relative passed default get sorted first when they exist within the prompting directory. We still need to find a good way to indicate the default in file completions when that isn't the case, see #400.