-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selectrum-default-value-format customizable variable #445
Conversation
For simplicity I went with the format string approach for now. This is also more aligned with I find the current candidate highlighting a bit questionable. Maybe it would be okay to always use the minibuffer-prompt face? (if (and selectrum--current-candidate-index
(< selectrum--current-candidate-index
0))
'selectrum-current-candidate
'minibuffer-prompt))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
What about this question:
|
* This variable allows the user to customize the format of the default value indicator * The variable can also be nil in order to hide the indicator * Do not remove the properties from the candidate string, for example Consult uses candidate strings with the invisible property * PR #445 * Issue #444
I don't know I don't think I would like that, using the same face as for candidates makes it look like a usual candidate which I like.
I'm not picky about it but if its not part of the spec than why not use |
Okay, so keep it as is? Then I am finished with the PR - ready to merge. |
Thanks! |
of the default value indicator
for example Consult uses candidate strings with the invisible
property