Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cycling for in completion in region #456

Conversation

clemera
Copy link
Collaborator

@clemera clemera commented Feb 22, 2021

See #419
@minad I did it a bit differently since in Selectrum we filter the collection only initially with a different style and I would like to keep that behavior. You might want to update the consult version for completion--cycle-threshold as this also checks for possibly defined threshold by metadata.

@clemera clemera force-pushed the support-cycling-for-in-buffer-completion branch 2 times, most recently from 8d15ea5 to 3f3b38c Compare February 22, 2021 16:50
@clemera clemera force-pushed the support-cycling-for-in-buffer-completion branch from 3f3b38c to e95cf70 Compare February 22, 2021 16:50
@clemera clemera changed the title Support cycling for in buffer completion Support cycling for in completion in region Feb 22, 2021
@clemera clemera merged commit e7341f0 into radian-software:master Feb 22, 2021
@minad
Copy link
Contributor

minad commented Feb 22, 2021

Thank you. I wonder why you want this behavior of filtering initially with a different style. Why does this make sense?

@minad
Copy link
Contributor

minad commented Feb 22, 2021

I found the discussion in minad/consult#218, reading through this now.

@clemera
Copy link
Collaborator Author

clemera commented Feb 22, 2021

For the completion itself (after invocation) I think it makes sense to use the same styles as usually but the initial filtering is the spot that I would like to be different. I also like the feature of using all-completion for that which makes the initial invocation faster. Also this approach fits better into Selectrum because filtering can be adjusted by other means than completion-styles (for example when using prescient).

@minad
Copy link
Contributor

minad commented Feb 22, 2021

Okay, thank you for explaining again. I still don't see where I would want this, maybe in combination with Prescient filtering. But I hope Prescient moves to completion styles soon.

@clemera
Copy link
Collaborator Author

clemera commented Feb 22, 2021

I like the speed boost with all-completions and I don't know why there should be different styles afterwards. Having prescient switching to completion styles would be nice, though it kind of seems like a duplicated effort with orderless already present.

@minad
Copy link
Contributor

minad commented Feb 22, 2021

Having prescient switching to completion styles would be nice, though it kind of seems like a duplicated effort with orderless already present.

Agree. My favorite solution for Prescient would be if it just drops the filtering part, and recommends Orderless instead for filtering.

@clemera
Copy link
Collaborator Author

clemera commented Feb 22, 2021

I suggested that in the past, see the discussion here, maybe it could be reconsidered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants