-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cycling for in completion in region #456
Support cycling for in completion in region #456
Conversation
8d15ea5
to
3f3b38c
Compare
3f3b38c
to
e95cf70
Compare
Thank you. I wonder why you want this behavior of filtering initially with a different style. Why does this make sense? |
I found the discussion in minad/consult#218, reading through this now. |
For the completion itself (after invocation) I think it makes sense to use the same styles as usually but the initial filtering is the spot that I would like to be different. I also like the feature of using |
Okay, thank you for explaining again. I still don't see where I would want this, maybe in combination with Prescient filtering. But I hope Prescient moves to completion styles soon. |
I like the speed boost with |
Agree. My favorite solution for Prescient would be if it just drops the filtering part, and recommends Orderless instead for filtering. |
I suggested that in the past, see the discussion here, maybe it could be reconsidered. |
See #419
@minad I did it a bit differently since in Selectrum we filter the collection only initially with a different style and I would like to keep that behavior. You might want to update the consult version for
completion--cycle-threshold
as this also checks for possibly defined threshold by metadata.