finish up oAuth cleanup #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… callback route ref #65
maxgrossman
added a commit
that referenced
this pull request
Aug 30, 2019
* beginning work on oAuth implementation... ref #52 * working on adding db migrations.... ref #52 * add new / update existing migration scripts. clean package depenedencies... ref #52 * remove stray console log.... ref #52 * first step to get callback endpoint working... ref #52 * jwt key in config... ref #52 * ...working on tdd for crud/jwt authentication ref #52 * working on adding jwt auth schema to service for securing crud routes... refs #52 * add jwt scheme/strategy test... ref #52 * work through additional tests for securing routes with JWT ref #52 * remove handlers/route files we now have in ${name.of.route}/index.js ref #52 * update some docs in the config file ref #52 * update fixture docs ref #52 * some better development docs... ref #52 * add back presetConfig that I whacked!!! ref #52 * no need for multiple path params, move no-auth get configuration to config map ref #52 * add login/callback test, use jwt expiration, add session route, configure circle to work with JWT authentication (#60) * initial user agent implementation ref #58 * work on login/callback tests... ref #58 * adding additional test for login/callback ref #58 * ...additional tests for callback ref #58 Signed-off-by: Max Grossman <m.grossman1813@gmail.com> * move callback route's session logic to pre method refs #58 #57 * add session route and accompianing test ref #58 * add db folder in job command ref #58 * put fake env_vars right in circleci build_and_test script ref #58 * has to be called build I guess! ref #58 * maybe try the dependecy cache steps? ref #58 * lint fixes ref #58 * update babel/eslint dependency versions ref #58 * make sure to pass jwt for mapcss resource tests ref #58 * no need for request-debug ref #58 * add logout (#62) * initial user agent implementation ref #58 * work on login/callback tests... ref #58 * adding additional test for login/callback ref #58 * ...additional tests for callback ref #58 Signed-off-by: Max Grossman <m.grossman1813@gmail.com> * move callback route's session logic to pre method refs #58 #57 * add session route and accompianing test ref #58 * add db folder in job command ref #58 * put fake env_vars right in circleci build_and_test script ref #58 * has to be called build I guess! ref #58 * maybe try the dependecy cache steps? ref #58 * lint fixes ref #58 * update babel/eslint dependency versions ref #58 * make sure to pass jwt for mapcss resource tests ref #58 * no need for request-debug ref #58 * add logout test...need to update other tests #61 * make sure the seedData's session record has initial value for presetConfig/mapcss tests ref #61 * run all tests and fix a bunch, move handlers over to routes... ref #61 * get rid of handlers!! ref #61 * use json like before... ref #61 * move auth all to index ref #61 * better enforce http response conventions throughout routes (#64) * clean up end of lines and add back the .gitkeep ref #61 * tdd for authentication error codes... ref #63 * fix josmPresets! ref #63 * update http response expectations for different routes & update circle config ref #63 * add the line endings!! ref #63 * clean up and add endlines ref #52 * finish up oAuth cleanup (#66) * working on updating cb url ref #65 * add verify route and use jwt as httpOnly cookie ref #65 * add needed cors headers for cross origin ref #65 * add get user route to handle when session is valid but localstorage lacks user ref #65 * add cors to route ref #65 * add more cors configurations, make cookie include access to everythign at / ref #65 * update tests so they put jwt in cookie header and respond redirect in callback route ref #65 * reach 95% coverage and unveil good bug to fix (I think)! ref #65 * simplify auth test and remove some lines of code to get coverage working ref #65 * initial explore route ref #65 * include preset name. ref #65 * lint, update icon lookup test ref #65 * remove console log ref #65 * update test after re-building icon map ref #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65