Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructured asset role types and clarified usage of the roles #1291

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Restructured asset role types and clarified usage of the roles #1291

merged 2 commits into from
Jun 28, 2024

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jun 27, 2024 •
edited
Loading

Related Issue(s): #1272

Proposed Changes:

  1. Fixes Clarify difference between thumbnail and overview #1272
  2. Generally reworks the asset roles types, also proposes some for collections etc.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.1 milestone Jun 27, 2024
@m-mohr m-mohr self-assigned this Jun 27, 2024
@m-mohr m-mohr changed the title Restructured asset role types and clarified usage of the roles `thumb… Restructured asset role types and clarified usage of the roles Jun 27, 2024
@m-mohr m-mohr requested a review from gadomski June 27, 2024 17:23
@m-mohr m-mohr linked an issue Jun 27, 2024 that may be closed by this pull request
Clarify difference between thumbnail and overview #1272
Closed
@m-mohr m-mohr requested review from cholmes and jbants June 27, 2024 22:14
jbants
jbants approved these changes Jun 28, 2024
View reviewed changes
best-practices.md Show resolved Hide resolved
@m-mohr m-mohr merged commit b9190e8 into dev Jun 28, 2024
1 check was pending
@m-mohr m-mohr deleted the roles branch June 28, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

@jbants jbants jbants approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

@gadomski gadomski Awaiting requested review from gadomski

@cholmes cholmes Awaiting requested review from cholmes

Assignees

@m-mohr m-mohr

Labels
documentation
Projects
None yet
Milestone
1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.

Clarify difference between thumbnail and overview
3 participants
@m-mohr @emmanuelmathot @jbants