Profiles => Extensions #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhanson
approved these changes
Aug 22, 2018
cholmes
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
Looks good!
I did forget that I had the distinction between functionality and content, which was how I was using profile vs extension. But I still like calling them both 'extensions'.
Happy to collapse them now. Perhaps a way to handle it in the future is 'extensions to json spec' vs 'extensions to api spec' or something like that...
This was referenced Aug 23, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Gitter, profiles and extensions are used synonymous anyway.