-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make datetime nullable for stac items for which a nominal datatime makes no sense #798
Conversation
### Date and Time Range | ||
| Field Name | Type | Description | | ||
| ---------- | ------------ | ----------- | | ||
| datetime | string\|null | See the [Item Spec Fields](item-spec.md#properties-object) for more information. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's valuable to mention this here so that we have a full overview here. Otherwise you have one field in the Item Spec and all the other here, which is a bit confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think I would like to add a 'best practices' section that discusses datetimes, explaining why it's good to have a nominal date time if possible, and explaining the use cases (zarr, etc) where it doesn't make sense. Plus more encouraging people to define extensions for their data (not just for ones with time ranges), that are more precise with what the datetime means (satellite imagery is acquisition time, mosaics are a representative time for search, and should use start/end, etc) And the implications for servers / clients.
But I can do it in its own PR, this one is the core spec mods we need.
### Date and Time Range | ||
| Field Name | Type | Description | | ||
| ---------- | ------------ | ----------- | | ||
| datetime | string\|null | See the [Item Spec Fields](item-spec.md#properties-object) for more information. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Related Issue(s): #792
Proposed Changes:
PR Checklist: