-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos and minor edits -- dev #873
Conversation
1.0.0-beta.2 release
fusion est dans une branche de sujet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements @ymoisan !
Thank you, I must admit I don't like all the whitespace changes, which may lead us into merge conflicts and thus I'm hesistant to approve this... |
@m-mohr I agree this is quite bothersome. Let me check if I can make things better in my editor settings (Atom). |
@ymoisan - any word on the whitespace stuff? Agree it'll help with a cleaner PR, and it'd be great to get these edits in. |
@cholmes I'm fighting with Atom on that. Such a drag. Let me try and push something later this week. Thanx for following up ... |
Easiest could probably be to just re-do the PR with another Editor ;-) |
@m-mohr good old gedit made things less bad but it's still not perfect. OK with you or you want me to try real hard :-) ? |
Okay with me, thank you for taking the effort, that looks pretty good now. Approved and merged! |
Replaces PR 871.
Related Issue(s): #
Proposed Changes:
PR Checklist: