Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and minor edits -- dev #873

Merged
merged 8 commits into from
Dec 14, 2020
Merged

Typos and minor edits -- dev #873

merged 8 commits into from
Dec 14, 2020

Conversation

ymoisan
Copy link
Contributor

@ymoisan ymoisan commented Jul 17, 2020

Replaces PR 871.

Related Issue(s): #

Proposed Changes:

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@ymoisan ymoisan changed the title Dev Typos and minor edits -- dev Jul 17, 2020
Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @ymoisan !

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 12, 2020

Thank you, I must admit I don't like all the whitespace changes, which may lead us into merge conflicts and thus I'm hesistant to approve this...

@ymoisan
Copy link
Contributor Author

ymoisan commented Nov 13, 2020

@m-mohr I agree this is quite bothersome. Let me check if I can make things better in my editor settings (Atom).

@cholmes
Copy link
Contributor

cholmes commented Dec 11, 2020

@ymoisan - any word on the whitespace stuff? Agree it'll help with a cleaner PR, and it'd be great to get these edits in.

@ymoisan
Copy link
Contributor Author

ymoisan commented Dec 14, 2020

@cholmes I'm fighting with Atom on that. Such a drag. Let me try and push something later this week. Thanx for following up ...

@m-mohr
Copy link
Collaborator

m-mohr commented Dec 14, 2020

Easiest could probably be to just re-do the PR with another Editor ;-)

@m-mohr m-mohr added this to the 1.0.0-beta.3 milestone Dec 14, 2020
@ymoisan
Copy link
Contributor Author

ymoisan commented Dec 14, 2020

@m-mohr good old gedit made things less bad but it's still not perfect. OK with you or you want me to try real hard :-) ?

@m-mohr m-mohr merged commit 5af8081 into radiantearth:dev Dec 14, 2020
@m-mohr
Copy link
Collaborator

m-mohr commented Dec 14, 2020

Okay with me, thank you for taking the effort, that looks pretty good now. Approved and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants