Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sat Extension] Additional acquisition parameters #894

Merged
merged 14 commits into from
Nov 30, 2020

Conversation

emmanuelmathot
Copy link
Collaborator

Proposed Changes:

  1. [Sat extension] Additional acquisition parameters

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

extensions/sat/README.md Outdated Show resolved Hide resolved
extensions/sat/README.md Show resolved Hide resolved
extensions/sat/README.md Outdated Show resolved Hide resolved
extensions/sat/README.md Outdated Show resolved Hide resolved
extensions/sat/json-schema/schema.json Outdated Show resolved Hide resolved
@emmanuelmathot
Copy link
Collaborator Author

Hello. Can we move on this PR? @m-mohr Do the reviews need more clarifications?

Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is looking good. I made a couple comments, but I think the overall thing is just add a bit more 'why' to the descriptions, help people understand what these are used for. But thanks for the contribution, it's great to see these suggestions come from working with the spec and data.

extensions/sat/README.md Outdated Show resolved Hide resolved
extensions/sat/README.md Outdated Show resolved Hide resolved
extensions/sat/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments :-)

extensions/sat/README.md Outdated Show resolved Hide resolved
extensions/sat/README.md Outdated Show resolved Hide resolved
extensions/sat/examples/example-sentinel1.json Outdated Show resolved Hide resolved
extensions/sat/examples/example-sentinel1.json Outdated Show resolved Hide resolved
extensions/sat/json-schema/schema.json Outdated Show resolved Hide resolved
extensions/sat/json-schema/schema.json Outdated Show resolved Hide resolved
emmanuelmathot and others added 5 commits September 17, 2020 20:00
Co-authored-by: Chris Holmes <chomie@gmail.com>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
extensions/sat/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one minor english tweak. Thanks!

Co-authored-by: Chris Holmes <chomie@gmail.com>
@m-mohr m-mohr self-requested a review September 21, 2020 10:11
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's looks good to be merged in the spec. I'm personally neutral on these changes, but I need to approve after I have requested changes so I'll approve to unblock the merge. Nevertheless, I'd be happy if more data providers could look over the changes and approve them. So I'm not merging myself, although the required number of 2 reviewers have been reached.

CHANGELOG.md Outdated Show resolved Hide resolved
@emmanuelmathot
Copy link
Collaborator Author

So it's looks good to be merged in the spec. I'm personally neutral on these changes, but I need to approve after I have requested changes so I'll approve to unblock the merge. Nevertheless, I'd be happy if more data providers could look over the changes and approve them. So I'm not merging myself, although the required number of 2 reviewers have been reached.

Ok, so how do we proceed? Is there something we can do?

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 4, 2020

@emmanuelmathot Maybe get another "independent" voice that confirms that these changes make sense to them as well and/or they use these fields?

@cholmes
Copy link
Contributor

cholmes commented Nov 30, 2020

I'm fine to merge this. If it was in core I'd want more independent review, but I'm ok in an extension. I think it's good to provide more optional fields, instead of making everyone come up with their own. If one of the field names ends up totally wrong we can deprecate it and add a new one, without breaking backwards compatability.

@cholmes cholmes merged commit b27242c into radiantearth:dev Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants