-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CARD4L SAR Extension (NRB + POL) #922
Conversation
a8cefa1
to
ea59ad9
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. One minor typo fix that I tried to put as a commitable suggestion. Psyched to see this added to STAC.
Co-authored-by: Chris Holmes <chomie@gmail.com>
# Conflicts: # CHANGELOG.md
@fangfy Thank you for your comments, very much appreciated! Sorry for the delay, I was waiting for #907 to be merged.
I understand the spec the way that view:incidence_angle indeed is intended to be for the sensor.
@matthewhanson What do you think? You proposed RTC, but what would be the preferred way out? Should we add more product types for SAR or go another route?
We are likely not capturing all details in STAC, but they are available in the additional XML file that is required anyway, right?
We've recently introduced the processing extension with PR #907. There are now fields for things like software + version and I'll add that now to the proposal. |
d75ae87
to
6b26599
Compare
CARD4L doesn't require XML, if all required metadata can be provided in STAC, then only one metadata file is needed. |
efc58b0
to
da7e36f
Compare
da7e36f
to
e9c3ac9
Compare
I've finished writing up the document that captures (I hope) all requirements from CARD4L SAR NRB and POL in a single STAC extensions. It got pretty heavy and was quite a bit of effort, but I've now also included a "pure" STAC mode, if you don't want the XML derived from the CARD4L metadata spec. The question is how to proceed with this? Is there a way to get that through some CEOS review or so? For example there is an open question re 1.7.3 in the document... In the best case we could finalize it with CEOS and actually make it somewhat official or so. Read it here: https://github.com/radiantearth/stac-spec/blob/card4l-sar-nrb/extensions/card4l-sar/README.md |
791d74b
to
67d1132
Compare
Problem is the _azimuth and _range part, which are relative to sensor not ground, so they don't apply to card4L product.
The units are different for the different images, hence it's important.
They are listed as parameters in the backscatter measurements (3.1). They do apply directly to the backscatter images/assets. I hope these help to clarify. Thanks heaps for implementing these! |
Thank you again, @fangfy!
In #962 I'm now proposing some additional fields to be added to the SAR extension. I hope I understood things correctly with my limited SAR knowledge. Thus there are separate fields for row and column. I'd appreciate if you could have a look at PR #962.
I was not giving the idea clear enough, I think. I meant if it's a fixed unit for the individual assets, one may not give them, but I'm fine to just leave them in and make it explicit.
Thank you, I found them now and also looked at POL again to align better. I have also tried to add those to the SAR extension directly, see #962. |
# Conflicts: # CHANGELOG.md
1051a45
to
4546ca6
Compare
6343d93
to
c0ca9d0
Compare
The STAC CARD4L SAR Extension has been migrated to a separate repository: https://github.com/stac-extensions/card4l/tree/main/sar |
The STAC CARD4L SAR Extension has been migrated to a separate repository: https://github.com/stac-extensions/card4l/tree/main/sar