Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version to 18.12.0 LTS #431

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Bump node version to 18.12.0 LTS #431

merged 1 commit into from
Nov 7, 2022

Conversation

rudolfs
Copy link
Member

@rudolfs rudolfs commented Sep 30, 2022

Also use the same node version consistently across local dev, CI and production environments.

@rudolfs rudolfs requested a review from cloudhead as a code owner September 30, 2022 16:28
@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from d843b6a to 38b2e67 Compare September 30, 2022 16:30
@rudolfs rudolfs requested a review from sebastinez September 30, 2022 16:30
@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from 38b2e67 to 9518d5b Compare September 30, 2022 16:36
Copy link
Contributor

@cloudhead cloudhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There used to be an issue with later node versions that made us go back to an earlier one, but @sebastinez will maybe remember more.

@rudolfs
Copy link
Member Author

rudolfs commented Oct 4, 2022

There used to be an issue with later node versions that made us go back to an earlier one, but @sebastinez will maybe remember more.

IIRC it was Cypress, which we upgraded recently, so that requirement is no more.

@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from 9518d5b to 1aed7b0 Compare October 4, 2022 06:39
@rudolfs
Copy link
Member Author

rudolfs commented Oct 4, 2022

TODO:

  • fix warning -> seems to be an issue with coc-svelte it seems

Screenshot 2022-10-04 at 08 43 10

  • fix go-to-definition stopped working, also seems to be coc-svelte related
  • test more extensively

@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from 1aed7b0 to ded1a09 Compare October 4, 2022 14:37
@rudolfs rudolfs added the hold label Oct 4, 2022
@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from ded1a09 to f587111 Compare November 3, 2022 12:32
@rudolfs rudolfs changed the title Bump node version to 18.10.0 Bump node version to 18.12.0 LTS Nov 3, 2022
@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from f587111 to a6c9f2a Compare November 3, 2022 12:38
@rudolfs
Copy link
Member Author

rudolfs commented Nov 3, 2022

So turns out coc-svelte is unmaintained. Made a fork and fixed the issues with it not being compatible with node 18.

Here are my init.vim changes:

+Plug 'rudolfs/coc-svelte', {'do': 'yarn install --frozen-lockfile'}

-let g:coc_global_extensions = ['coc-tsserver', 'coc-tslint-plugin', 'coc-svelte', 'coc-rust-analyzer', 'coc-json', 'coc-prettier', 'coc-eslint']
+let g:coc_global_extensions = ['coc-tsserver', 'coc-tslint-plugin', 'coc-rust-analyzer', 'coc-json', 'coc-prettier', 'coc-eslint']

Had to uninstall the original coc-svelte plugin with :CocUninstall coc-svelte and then run PlugInstall.

@rudolfs rudolfs removed the hold label Nov 3, 2022
@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from a6c9f2a to 9ab1119 Compare November 4, 2022 14:53
Copy link
Member

@sebastinez sebastinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs rudolfs force-pushed the rudolfs/upgrade-node branch from 9ab1119 to 7088a99 Compare November 7, 2022 14:23
@rudolfs rudolfs merged commit 7088a99 into master Nov 7, 2022
@rudolfs rudolfs deleted the rudolfs/upgrade-node branch November 7, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants