Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #622

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Update dependencies #622

merged 2 commits into from
Feb 27, 2023

Conversation

rudolfs
Copy link
Member

@rudolfs rudolfs commented Feb 22, 2023 •
edited
Loading

To keep us up-to-date. This also updates transitive dependencies.

@rudolfs rudolfs requested a review from cloudhead as a code owner February 22, 2023 14:05
@rudolfs rudolfs requested a review from sebastinez February 22, 2023 14:05
@rudolfs rudolfs marked this pull request as draft February 22, 2023 14:25
@sebastinez
Copy link
Member

It seems that the build smoke test is failing because of microsoft/playwright#21106

@rudolfs
Copy link
Member Author

rudolfs commented Feb 23, 2023

It seems that the build smoke test is failing because of microsoft/playwright#21106

Oh, good catch. I was trying to figure this out yesterday, but couldn't find what was wrong with it.

@rudolfs
Copy link
Member Author

rudolfs commented Feb 23, 2023

There seems to be a regression in FF: microsoft/playwright#21145.

@sebastinez
Copy link
Member

There seems to be a regression in FF: microsoft/playwright#21145.

Maybe we should exclude playwright from this update? Since there are some other dependencies that are either major updates or at least minor ones.

@rudolfs
Copy link
Member Author

rudolfs commented Feb 27, 2023

Maybe we should exclude playwright from this update? Since there are some other dependencies that are either major updates or at least minor ones.

Yeah, can do.

@rudolfs
Update dependencies
55cc5c3 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
sebastinez
sebastinez approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@sebastinez sebastinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to work nicely

@rudolfs
Copy link
Member Author

rudolfs commented Feb 27, 2023

Hm, on second thought, I think this won't work, because the problem seems to be with the newer firefox browser version. And we don't have a way to not update the browsers when bumping deps. So we either disable the firefox tests or wait for playwright to fix it on their end.

@sebastinez
Copy link
Member

Hm, on second thought, I think this won't work, because the problem seems to be with the newer firefox browser version. And we don't have a way to not update the browsers when bumping deps.

So we are kinda vendor locked in by Microsoft 😅

@rudolfs
Disable Firefox checks until Playwright is fixed
d71f47a 
See microsoft/playwright#21145 for more
details.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs rudolfs marked this pull request as ready for review February 27, 2023 15:33
@rudolfs rudolfs merged commit d71f47a into master Feb 27, 2023
@rudolfs rudolfs deleted the rudolfs/bump-deps branch February 27, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastinez sebastinez sebastinez approved these changes

@cloudhead cloudhead Awaiting requested review from cloudhead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudolfs @sebastinez