Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): use PEP-655 NotRequired #191

Merged
merged 1 commit into from
Mar 25, 2024
+4 −4
Merged

fix(typing): use PEP-655 NotRequired #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions acrclient/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from __future__ import annotations

from typing import TypedDict
from typing import NotRequired, TypedDict


class GetBmCsProjectsResultsParams(TypedDict): # pragma: no cover
Expand All @@ -12,9 +12,9 @@ class GetBmCsProjectsResultsParams(TypedDict): # pragma: no cover
"""last: get the last results, day: get the day results, Default is day"""
date: str
"""Get all the results on this date. The format is YYYYmmdd (E.g. 20210201)"""
min_duration: int | None
min_duration: NotRequired[int | None]
"""Return the results of played_duration >= min_duration seconds (default: 0)"""
max_duration: int | None
max_duration: NotRequired[int | None]
"""Return results with played_duration <= max_duration seconds (default: 3600)"""
isrc_country: str | None
isrc_country: NotRequired[str | None]
"""Only return results that match the isrc country code (E.g. DE, FR, IT, US)"""