[Select] When there's no value or defaultValue, align with first non-disabled item
#1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
commented
May 9, 2022
andy-hook
reviewed
May 10, 2022
benoitgrelard
commented
May 10, 2022
Co-authored-by: Andy Hook <hello@andy-hook.co.uk>
andy-hook
approved these changes
May 10, 2022
|
Hey @benoitgrelard , this issues is still happening on the CodeSandbox link example of the https://codesandbox.io/s/5exdpd?module=App.js If you remove the |
|
Hey @MatheusPires99, it's available in latest release candidates. V1 is going out imminently (should be tomorrow). |
|
Oh nice to hear that. I will wait to check the v1 then. Thanks a lot @benoitgrelard |
luisorbaiceta
pushed a commit
to luisorbaiceta/primitives
that referenced
this pull request
Jul 21, 2022
…non-disabled item (radix-ui#1379) * Do not lie about content context type * Add story for alignment without default value * Align with first valid item when no value is set * Versions * Update Select.stories.tsx * Apply suggestions from code review Co-authored-by: Andy Hook <hello@andy-hook.co.uk> * firstItemRef -> firstValidItemFoundRef * PR feedback * Rename ref callbacks * PR feedback Co-authored-by: Andy Hook <hello@andy-hook.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1324
I've managed to do even slightly better than we had tested. It will now align not with the first item, but the first non-disabled item. This gives a better experience if some of the first items are disabled.
I've added a chromatic story for it too.