[Switch] fix : Hidden input for Switch does not render "over the button" #3250
+42
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the issue where BubbleInput was positioned incorrectly - Adjusted positioning by wrapping with a div to align the Input within the Button area
Brokyeom
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
Brokyeom
changed the title
Brokyeom
commented
Nov 24, 2024
| Wrap with div to prevent input from escaping component bounds | ||
| link : https://github.com/radix-ui/primitives/issues/3235 | ||
| */} | ||
| <div style={{ position: 'relative', display: 'inline-flex' }}> |
| // We transform because the input is absolutely positioned but we have | ||
| // rendered it **after** the button. This pulls it back to sit on top | ||
| // of the button. | ||
| style={{ transform: 'translateX(-100%)' }} |
There was a problem hiding this comment.
Remove transform inline style.
Brokyeom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3235
Description
The BubbleInput within the Switch component had an absolute positioning applied, but there was no parent node with relative positioning, causing the component to overflow its intended area.
<Primitive.button />and<BubbleInput />and applied the necessary styles.transform: translate(-100%)property previously applied as an inline style on BubbleInput.AS-IS
TO-BE
Test Result
Storybook