Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Margins and dapp names #307

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Dec 20, 2024

(Replaces #304 which was created against my fork before I had write perms, but that meant the tests couldn't run)

Overview

Fixes the couple of issues from #303 - notably:

  • If someone doesn't provide a dAppName, I use dApp so it doesn't look weird
  • I've reduced the superfluous lower padding on the Requests tab (which was coming from a few sources)
  • The blurred edge mask to hint that there's a scroll bar still:
    • Still exists, and now has a fix height of 10px
    • Still isn't visible if scrolled fully to the bottom
    • Has been redefined slightly so that it doesn't need any overrides on different screens or screen sizes any more
  • The max height of the content of the Sharing tab is larger, in line with the requests tab (it often requires I scroll at the moment, this should improve matters)

Testing

  • I've manually gone through all the storybook on mobile/non-mobile mode

Before / After

@dawidsowardx dawidsowardx merged commit 0a984d0 into develop Jan 14, 2025
20 of 22 checks passed
Copy link

🎉 This PR is included in version 2.2.1-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants