Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the min rounds per epoch #1928

Merged
merged 10 commits into from
Sep 27, 2024
Merged

Change the min rounds per epoch #1928

merged 10 commits into from
Sep 27, 2024

Conversation

0xOmarA
Copy link
Member

@0xOmarA 0xOmarA commented Sep 26, 2024

Summary

Updates the min rounds per epoch in cuttlefish to be 100

@0xOmarA 0xOmarA changed the base branch from main to develop September 26, 2024 18:29
@github-actions GitHub Actions
Copy link

Phylum Report Link

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-scrypto-builder:327b5d1451

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Benchmark for 327b5d1

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 45.1±0.12ms 44.9±0.11ms -0.44%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.0±0.11ms 18.9±0.03ms -0.53%
costing::decode_encoded_i8_array_to_manifest_value 41.9±0.18ms 43.1±0.17ms +2.86%
costing::decode_encoded_tuple_array_to_manifest_raw_value 69.6±0.09ms 71.4±0.16ms +2.59%
costing::decode_encoded_tuple_array_to_manifest_value 120.2±1.31ms 103.0±0.23ms -14.31%
costing::decode_encoded_u8_array_to_manifest_raw_value 31.8±0.12µs 26.6±0.05µs -16.35%
costing::decode_encoded_u8_array_to_manifest_value 42.3±0.18ms 43.1±0.16ms +1.89%
costing::decode_rpd_to_manifest_raw_value 14.6±0.05µs 14.0±0.05µs -4.11%
costing::decode_rpd_to_manifest_value 10.7±0.01µs 13.6±0.05µs +27.10%
costing::deserialize_wasm 1277.3±4.40µs 1252.3±4.34µs -1.96%
costing::execute_transaction_creating_big_vec_substates 699.0±6.81ms 716.0±11.85ms +2.43%
costing::execute_transaction_reading_big_vec_substates 608.4±4.01ms 610.3±3.88ms +0.31%
costing::instantiate_flash_loan 889.5±238.63µs 858.1±263.49µs -3.53%
costing::instantiate_radiswap 1025.5±1067.52µs 1015.3±1078.02µs -0.99%
costing::spin_loop 20.7±0.06ms 21.1±0.06ms +1.93%
costing::validate_sbor_payload 32.4±0.09µs 32.1±0.10µs -0.93%
costing::validate_sbor_payload_bytes 246.3±0.84ns 247.9±0.75ns +0.65%
costing::validate_secp256k1 76.8±0.16µs 76.7±0.16µs -0.13%
costing::validate_wasm 33.7±0.04ms 33.8±0.04ms +0.30%
decimal::add/0 8.4±0.00ns 8.4±0.01ns 0.00%
decimal::add/rust-native 9.9±0.01ns 9.9±0.01ns 0.00%
decimal::add/wasmi 227.9±0.39ns 220.6±0.32ns -3.20%
decimal::add/wasmi-call-native 2.0±0.00µs 2.1±0.00µs +5.00%
decimal::div/0 185.0±0.12ns 185.7±0.08ns +0.38%
decimal::from_string/0 155.2±0.25ns 154.6±0.23ns -0.39%
decimal::mul/0 149.3±0.17ns 149.3±0.15ns 0.00%
decimal::mul/rust-native 148.8±0.27ns 147.4±0.33ns -0.94%
decimal::mul/wasmi 11.9±0.05µs 11.9±0.06µs 0.00%
decimal::mul/wasmi-call-native 2.2±0.00µs 2.2±0.00µs 0.00%
decimal::pow/0 699.7±0.70ns 689.3±0.50ns -1.49%
decimal::pow/rust-native 668.5±0.36ns 667.3±0.99ns -0.18%
decimal::pow/wasmi 56.5±0.30µs 57.2±0.26µs +1.24%
decimal::pow/wasmi-call-native 2.5±0.00µs 2.5±0.02µs 0.00%
decimal::root/0 7.7±0.01µs 7.8±0.01µs +1.30%
decimal::sub/0 8.2±0.00ns 8.2±0.00ns 0.00%
decimal::to_string/0 443.3±0.78ns 445.3±1.54ns +0.45%
large_transaction_processing::prepare 2.6±0.00ms 2.7±0.00ms +3.85%
large_transaction_processing::prepare_and_decompile 7.1±0.02ms 7.0±0.03ms -1.41%
large_transaction_processing::prepare_and_decompile_and_recompile 31.2±1.87ms 31.1±1.58ms -0.32%
precise_decimal::add/0 8.8±0.00ns 9.1±0.01ns +3.41%
precise_decimal::add/rust-native 10.7±0.01ns 10.7±0.03ns 0.00%
precise_decimal::add/wasmi 274.5±0.81ns 271.1±0.52ns -1.24%
precise_decimal::add/wasmi-call-native 2.8±0.00µs 2.7±0.00µs -3.57%
precise_decimal::div/0 323.6±0.29ns 318.0±1.01ns -1.73%
precise_decimal::from_string/0 201.7±0.10ns 202.3±0.12ns +0.30%
precise_decimal::mul/0 365.1±0.44ns 365.6±0.37ns +0.14%
precise_decimal::mul/rust-native 331.4±3.64ns 340.3±4.49ns +2.69%
precise_decimal::mul/wasmi 34.8±0.15µs 34.3±0.48µs -1.44%
precise_decimal::mul/wasmi-call-native 3.1±0.00µs 3.1±0.00µs 0.00%
precise_decimal::pow/0 1943.1±2.22ns 1931.7±3.40ns -0.59%
precise_decimal::pow/rust-native 1524.8±1.22ns 1538.1±2.57ns +0.87%
precise_decimal::pow/wasmi 165.6±1.44µs 167.4±2.70µs +1.09%
precise_decimal::pow/wasmi-call-native 5.7±0.01µs 5.7±0.01µs 0.00%
precise_decimal::root/0 62.4±0.07µs 61.8±0.06µs -0.96%
precise_decimal::sub/0 9.0±0.03ns 9.1±0.05ns +1.11%
precise_decimal::to_string/0 694.5±0.99ns 694.2±1.37ns -0.04%
schema::validate_payload 365.8±0.68µs 366.3±0.51µs +0.14%
transaction::radiswap 5.1±0.02ms 5.1±0.02ms 0.00%
transaction::transfer 1877.3±3.15µs 1876.7±7.64µs -0.03%
transaction_validation::validate_manifest 43.1±0.04µs 43.2±0.04µs +0.23%
transaction_validation::verify_bls_2KB 1069.2±17.59µs 1045.8±32.05µs -2.19%
transaction_validation::verify_bls_32B 1026.3±31.52µs 1064.4±15.15µs +3.71%
transaction_validation::verify_ecdsa 74.6±0.06µs 74.5±0.06µs -0.13%
transaction_validation::verify_ed25519 57.1±0.44µs 54.9±0.15µs -3.85%

dhedey
dhedey reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few suggestions to make it not break testnets

radix-transactions/src/builder/transaction_builder.rs Outdated Show resolved Hide resolved
radix-engine-tests/tests/protocol/consensus_manager.rs Outdated Show resolved Hide resolved
radix-engine/src/updates/cuttlefish.rs Outdated Show resolved Hide resolved
dhedey
dhedey approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks! :)

radix-engine-tests/assets/serialized_receipts/basic_subintents/create-accounts.json
@@ -0,0 +1,44 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm surprised this didn't error because they weren't regenerated... In a separate PR,

I would suggest in a separate PR that we either:

  • Move this into the scenario dumper.rs (probably slightly easier)
  • Keep it separate, and use a FolderContentAligner, and have separate update/validate methods, and add its update function to ./update-scenarios.sh so it will run when someone updates a scenario.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Will move this into the scenario in a separate PR.

@0xOmarA 0xOmarA merged commit 0b92ab2 into develop Sep 27, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamyulong iamyulong iamyulong left review comments

@dhedey dhedey dhedey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xOmarA @dhedey @iamyulong