Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 avoid external links to minify #14

Merged
merged 1 commit into from
Jan 26, 2022
Merged

🐛 avoid external links to minify #14

merged 1 commit into from
Jan 26, 2022

Conversation

contardi
Copy link

Description

When enabled Magento Minify, the external JS can't be merged and minified

Fixed Issues

Added to config.xml which JS must be excluded from JS Minification

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@rafaelstz rafaelstz self-assigned this Dec 27, 2021
@rafaelstz rafaelstz self-requested a review January 26, 2022 18:28
@rafaelstz rafaelstz added the bug Something isn't working label Jan 26, 2022
@rafaelstz rafaelstz modified the milestones: 2.0.6, 2.1.0 Jan 26, 2022
@rafaelstz
Copy link
Owner

Thank you @contardi 🎉

@rafaelstz rafaelstz merged commit 49a386d into rafaelstz:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants