Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taskJump and Remove missing toArrayFast #63

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix taskJump and Remove missing toArrayFast #63

merged 2 commits into from
Oct 24, 2023

Conversation

letovsk1y
Copy link
Contributor

@letovsk1y letovsk1y commented Oct 20, 2023

Fix PedMp taskJump definition

MulleDK19: Definition is wrong. This has 4 parameters (Not sure when they were added. v350 has 2, v678 has 4).

v350: Ped ped, bool unused
v678: Ped ped, bool unused, bool flag1, bool flag2

https://wiki.rage.mp/index.php?title=Player::taskJump
https://nativedb.dotindustries.dev/natives/0x0AE4086104E067B1

Remove missing Pool::toArrayFast method in types-server

Pool::toArrayFast in types-client works fine

This method has been missing for a very long time
and is unlikely to be added again: https://i.imgur.com/7sl0qU1.png

MulleDK19: Definition is wrong. This has 4 parameters (Not sure when they were added. v350 has 2, v678 has 4).

v350: Ped ped, bool unused
v678: Ped ped, bool unused, bool flag1, bool flag2
Pool::toArrayFast in types-client works fine

This method has been missing for a very long time
and is unlikely to be added again: https://i.imgur.com/7sl0qU1.png
@letovsk1y letovsk1y changed the title Fix PedMp taskJump definition Fix PedMp taskJump definition and Remove missing toArrayFast method Oct 24, 2023
@letovsk1y letovsk1y changed the title Fix PedMp taskJump definition and Remove missing toArrayFast method Fix PedMp taskJump and Remove missing toArrayFast method Oct 24, 2023
@letovsk1y letovsk1y changed the title Fix PedMp taskJump and Remove missing toArrayFast method Fix taskJump and Remove missing toArrayFast method Oct 24, 2023
@letovsk1y letovsk1y changed the title Fix taskJump and Remove missing toArrayFast method Fix taskJump and Remove missing toArrayFast Oct 24, 2023
@leonardssh leonardssh requested a review from ksenonadv October 24, 2023 09:16
@ksenonadv ksenonadv merged commit 0c9f17e into ragempcommunity:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants