Allow removal of balance limits in TokenNetwork

See #1481
raiden-network · Jul 29, 2021 · 5346cf6 · 5346cf6
1 parent bc7d429
commit 5346cf6
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/raiden_contracts/data/source/raiden/TokenNetwork.sol b/raiden_contracts/data/source/raiden/TokenNetwork.sol
@@ -11,6 +11,8 @@ import "raiden/Token.sol";
 import "raiden/Utils.sol";
 import "raiden/SecretRegistry.sol";
 
+uint256 constant MAX_INT = 2**256 - 1;
+
 /// @title TokenNetwork
 /// @notice Stores and manages all the Raiden Network channels that use the
 /// token specified in this TokenNetwork contract.
@@ -201,7 +203,7 @@ contract TokenNetwork is Utils {
     );
 
     modifier onlyDeprecationExecutor() {
-        require(msg.sender == deprecation_executor);
+        require(msg.sender == deprecation_executor, "Can only be called by deprecation_executor");
         _;
     }
 
@@ -1553,4 +1555,14 @@ contract TokenNetwork is Utils {
         pair_hash = getParticipantsHash(participant1, participant2);
         delete participants_hash_to_channel_identifier[pair_hash];
     }
+
+    /// @notice Removes the balance limits.
+    /// Can only be called by the deprecation_executor.
+    function removeLimits()
+        external
+        onlyDeprecationExecutor
+    {
+        channel_participant_deposit_limit = MAX_INT;
+        token_network_deposit_limit = MAX_INT;
+    }
 }
diff --git a/raiden_contracts/data/source/raiden/TokenNetworkRegistry.sol b/raiden_contracts/data/source/raiden/TokenNetworkRegistry.sol
@@ -6,8 +6,6 @@ import "raiden/Utils.sol";
 import "raiden/Token.sol";
 import "raiden/TokenNetwork.sol";
 
-uint256 constant MAX_INT = 2**256 - 1;
-
 /// @title TokenNetworkRegistry
 /// @notice The TokenNetwork Registry deploys new TokenNetwork contracts for the
 /// Raiden Network protocol.

diff --git a/raiden_contracts/tests/test_contract_limits.py b/raiden_contracts/tests/test_contract_limits.py
@@ -152,6 +152,14 @@ def test_participant_deposit_limit(
         {"from": B},
     )
 
+    # Now disable the limits and try again
+    with pytest.raises(TransactionFailed, match="Can only be called by"):
+        call_and_transact(token_network.functions.removeLimits())
+    call_and_transact(token_network.functions.removeLimits(), {"from": DEPLOYER_ADDRESS})
+    token_network.functions.setTotalDeposit(
+        channel_identifier, B, MAX_ETH_CHANNEL_PARTICIPANT + 1, A
+    ).call({"from": B})
+
 
 @pytest.mark.skip(reason="Only for local testing, otherwise it takes too much time to run.")
 def test_network_deposit_limit(
@@ -243,3 +251,7 @@ def send_remaining(
     D = create_account()
     with pytest.raises(TransactionFailed):
         create_channel(C, D)
+
+    # Now disable the limits and try again
+    call_and_transact(token_network.functions.removeLimits(), {"from": DEPLOYER_ADDRESS})
+    token_network.functions.setTotalDeposit(channel_identifier, A, 1, B).call({"from": A})