Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opening a new channel during a settlement period #916

Open
pirapira opened this issue May 2, 2019 · 10 comments
Open

Support opening a new channel during a settlement period #916

pirapira opened this issue May 2, 2019 · 10 comments
Labels
ABI change! Will require changes in the Raiden client enhancement New feature or request P2 demanded by somebody

Comments

@pirapira
Copy link
Contributor

pirapira commented May 2, 2019

When one channel is in the settlement period, the same pair of users should be able to create a new channel. Currently, a new channel can be created only after the first channel is settled.

@pirapira pirapira added P2 demanded by somebody enhancement New feature or request labels May 2, 2019
@pirapira pirapira added the ABI change! Will require changes in the Raiden client label Jun 20, 2019
@pirapira
Copy link
Contributor Author

pirapira commented Jul 1, 2019

For this, we need to remove

  • participants_hash_to_channel_identifier and
  • getChannelIdentifier()

I have to check whether getChannelIdentifier() is being used.

@pirapira
Copy link
Contributor Author

pirapira commented Jul 1, 2019

Not much, users usually remember the channel ID.

@pirapira pirapira self-assigned this Jul 1, 2019
@pirapira
Copy link
Contributor Author

pirapira commented Jul 8, 2019

I'll focus on #1087 now.

@pirapira pirapira removed their assignment Jul 8, 2019
@pirapira pirapira self-assigned this Jul 16, 2019
@pirapira
Copy link
Contributor Author

I had a chat with @rakanalh about this.

The TokenNetwork proxy sometimes call getChannelIdentifier(). I'll try replacing the calls with errors, and see that ever happens.

@pirapira
Copy link
Contributor Author

Somehow the client's smoketest calls getChannelIdentifier() raiden-network/raiden#4406.

@pirapira

This comment has been minimized.

@pirapira
Copy link
Contributor Author

I looked through the client code. I think it's easy to remove all calls on getChannelIdentifier().

@pirapira
Copy link
Contributor Author

Ah, but we need to change

 GET /api/(version)/channels/(token_address)/(partner_address)

to include a channel_id.

@pirapira
Copy link
Contributor Author

pirapira commented Jul 23, 2019

Also
https://raiden-network.readthedocs.io/en/stable/rest_api.html#post--api-(version)-payments-(token_address)-(target_address)

POST /api/(version)/payments/(token_address)/(target_address)

would need to contain a channel_identifier here. Are people willing to add a channel_id here?

Perhaps we can change getChannelIdentifier() into getOpenChannelIdentifier().

@pirapira
Copy link
Contributor Author

I'm finding relevant requirements: raiden-network/raiden#1769

As there should never exist more than 1 channel open for each tuple
(registry_address, token_address, own_address, partner_address)

So it's better to keep open channels unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI change! Will require changes in the Raiden client enhancement New feature or request P2 demanded by somebody
Projects
None yet
Development

No branches or pull requests

2 participants