Remove channel_identifier usage to search for channels #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This identifier has a nonce on the blockchain, which makes it very hard to be calculated only from the parameters given in the request. As there should never exist more than 1 channel open for each tuple (registry_address, token_address, own_address, partner_address), we can just use it to search for the channels we want to interact with. Channel_identifier is still returned in the request, for information, but its value is ignored in the tests. [ci integration]
[skip ci]
LefterisJP
approved these changes
Jul 10, 2018
|
The PR looks fine but @andrevmatos requested in a pm to wait a bit since there is some more tests outside the api tests that are related and he wants to address |
|
@andrevmatos Please open another PR to fix the rest of the tests you wanted. I want the tests fixed in master if the fix is available (and since you were so kind to provide it, it now is :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This identifier has a nonce on the blockchain, which makes it very hard
to be calculated only from the parameters given in the request.
As there should never exist more than 1 channel open for each tuple
(registry_address, token_address, own_address, partner_address), we can
just use it to search for the channels we want to interact with.
Channel_identifier is still returned in the request, for information,
but its value is ignored in the tests.
Fix #1765 , broken by the changes introduced in raiden-network/raiden-contracts#170