Contract limits #276
Merged
Contract limits #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loredanacirstea
force-pushed
the
contract-limits
branch
5 times, most recently
from
31c5aa2 to
9b004db
Compare
LefterisJP
reviewed
Sep 20, 2018
| // Bug bounty release deposit limit | ||
| uint256 public deposit_limit; | ||
| // Bug bounty release deposit limits | ||
| // The combined deposit of one channel is limited to 0,15 ETH. |
There was a problem hiding this comment.
nitpick: you are using a , for decimal separator here and a . in the line below. Choose one and stick to it.
loredanacirstea
force-pushed
the
contract-limits
branch
2 times, most recently
from
6ec99bc to
3a5d9b7
Compare
loredanacirstea
added a commit
to loredanacirstea/raiden-contracts
that referenced
this pull request
Sep 20, 2018
As mentioned in raiden-network#276 (comment)
The combined deposit of one channel is limited to 0,15 ETH. So per person 0.075 ETH. The total combined deposit of all channels across the whole network is limited to 250 ETH. There will be only one token network contract created.
loredanacirstea
force-pushed
the
contract-limits
branch
from
c128f04 to
41e9a64
Compare
loredanacirstea
added a commit
to loredanacirstea/raiden-contracts
that referenced
this pull request
Sep 21, 2018
As mentioned in raiden-network#276 (comment)
LefterisJP
reviewed
Sep 21, 2018
| // This should never fail at this point. Added check for security, because we directly set | ||
| // the participant_state.deposit = total_deposit, while we transfer `added_deposit` tokens. | ||
| assert(participant_state.deposit + added_deposit == total_deposit); | ||
|
|
||
| // Bug Bounty release token network limit |
There was a problem hiding this comment.
The bug bounty naming got reintroduced here through the rebase.
As mentioned in raiden-network#276 (comment)
loredanacirstea
force-pushed
the
contract-limits
branch
from
41e9a64 to
8759311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #262
To be reviewed after #275
The combined deposit of one channel is limited to 0,15 ETH. So per person 0.075 ETH.
The total combined deposit of all channels across the whole network is limited to 250 ETH.
Only one token network will be used.
Removed tests and test contracts for the old contract limits.