Upgrade Synapse to 1.19.1 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulope
force-pushed
the
upgrade/synapse-1.19.1
branch
9 times, most recently
from
bf627f1 to
e62a6f2
Compare
ulope
added a commit
to raiden-network/raiden-services
that referenced
this pull request
Sep 15, 2020
This is necessary after - raiden-network/raiden-service-bundle#187 - raiden-network/raiden#6442 With those PRs the set of federation servers can become disjunct between different Raiden client versions. Therefore we can't rely on the previous check in the Raiden client if the PFS' server is in the known servers set. The RoomID is uniquely identifying a specific broadcasting room and can therefore be used as a better information source for this check.
ulope
added a commit
to raiden-network/raiden-services
that referenced
this pull request
Sep 16, 2020
This is necessary after - raiden-network/raiden-service-bundle#187 - raiden-network/raiden#6442 With those PRs the set of federation servers can become disjunct between different Raiden client versions. Therefore we can't rely on the previous check in the Raiden client if the PFS' server is in the known servers set. The RoomID is uniquely identifying a specific broadcasting room and can therefore be used as a better information source for this check.
ulope
force-pushed
the
upgrade/synapse-1.19.1
branch
from
97034c3 to
7e0faa8
Compare
This will cut down on throwaway devices being generated.
Fixes: #181 (hopefully)
ulope
force-pushed
the
upgrade/synapse-1.19.1
branch
from
7e0faa8 to
5fa0a8b
Compare
fredo
approved these changes
Sep 21, 2020
| "transport.transport04.raiden.network", | ||
| "transport.transport05.raiden.network" | ||
| ] | ||
| } |
There was a problem hiding this comment.
For what reason do we need the distinction between active and all servers?
There was a problem hiding this comment.
Basically it's the outcome of raiden-network/raiden#6443.
We need a separate list for the Raiden clients and the server to server federation whitelist.
Incidentally this also fixes the problem of onboarding new RSBs since we can add them to the all_servers list (so they become whitelisted for the federation) without making them "visible" to Clients yet until they have fully joined the federation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #180
Fixes: raiden-network/raiden#6443