Handle correctly null associations #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
null belongs_to associations are now serialized as nil instead of raise an error during serialization.
|
👍 |
1 similar comment
|
👍 |
| @@ -133,7 +133,7 @@ def each_association(&block) | |||
| self.class._associations.dup.each do |name, options| | |||
| association = object.send(name) | |||
| serializer_class = ActiveModel::Serializer.serializer_for(association) | |||
| serializer = serializer_class.new(association) | |||
| serializer = serializer_class.new(association) if serializer_class | |||
There was a problem hiding this comment.
Just a sanity check: if serializer is not defined, line 139 will throw undefined error, no? Shouldn't we raise here instead if serializer_class is nil?
There was a problem hiding this comment.
no, this doesn't throw an undefined error, instead serializer is nil in line 139
kurko
added a commit
that referenced
this pull request
Oct 31, 2014
Handle correctly null associations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null belongs_to associations are now serialized as nil instead
of raise an error during serialization.