Instantiate observers via Railtie, and run load hooks #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spent some time figuring out how to cleanly use the
ActiveResource observer support in a Rails app, finding surprisingly
little documentation beyond ActiveModel::Observer itself, arriving at
the need for this essential boilerplate in an initializer:
ActiveResource::Base.observers = # ...
ActiveResource::Base.instantiate_observers
This change packages it up as neatly as ActiveRecord observers in Rails:
# In config/application.rb
config.active_resource.observers = [:post_observer, :comment_observer]
The Railtie will instantiate observers automatically, and reload them
for each request in development just like rails-observers does for
ActiveRecord.
|
Is there a mailing list where maintenance of ActiveResource is discussed? Is there anyone with release management privileges on the project who remotely cares about reviewing pull requests? |
guilleiguaran
added a commit
that referenced
this pull request
Jan 29, 2014
…and-load-hooks Instantiate observers via Railtie, and run load hooks
|
Thanks for merging @guilleiguaran! Sorry to gripe about the project activity, I just think it would be a "help me help you" to give the user base some news about the level of commitment maintainers are able to give at this point in time, and a venue for coordination if there are some others willing to step up to help. |
guilleiguaran
added a commit
that referenced
this pull request
Nov 30, 2015
…and-load-hooks Instantiate observers via Railtie, and run load hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time figuring out how to cleanly use the ActiveResource observer support in a Rails app, finding surprisingly little documentation beyond
ActiveModel::Observeritself, eventually arriving at the need for this essential boilerplate in an initializer:This change packages it up as neatly as ActiveRecord observers in Rails:
The Railtie instantiates observers automatically, and reloads them for each request in development just like rails-observers does for ActiveRecord.