Better check for Rails application #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -42,5 +42,5 @@ module ActiveResource | |||
| autoload :Collection | |||
| end | |||
|
|
|||
| require 'active_resource/railtie' if defined? Rails | |||
| require 'active_resource/railtie' if defined?(Rails) && defined?(Rails.application) | |||
There was a problem hiding this comment.
only defined?(Rails.application) is fine.
rafaelfranca
added a commit
that referenced
this pull request
Jun 17, 2016
Better check for Rails application
wkrsz
added a commit
to dropstream/wicked_pdf
that referenced
this pull request
Jan 26, 2017
Gems like rails-html-sanitizer open Rails namespace without requiring Rails. Instead check if Rails.env is defined. Similar to: rails/activeresource#216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't trigger loading of
railtiewhen there's onlyRailsconstant present. Previous version of the code tried to load it when there only was stuff likerails-observersofrails-html-sanitizer(which is a part of ActionMailer)