Use Arel::Nodes::BindParam in Oracle visitor for queries using both LIMIT and OFFSET #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rafaelfranca
added a commit
that referenced
this pull request
Oct 7, 2016
Use Arel::Nodes::BindParam in Oracle visitor for queries using both LIMIT and OFFSET
|
Backported in 8813ad8 |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Oct 11, 2016
rails/arel@8813ad8 Also Refer rails/arel#450 rails/arel#438 rsim#848 This fix itself has been available since Arel 7.1.3 but the latest version of Arel is 7.1.4.
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Nov 3, 2016
…index:: 3:` when `offset` and `limit` used at the same time with JRuby and Oracle 11gR2 or lower since rails/arel#450 needs 3 bind variables, `:a1`, `:a2` and `:a1` again. It is probably due to Oracle enhanced adapter JDBC implementation handles bind variables by their order not their name then we need to handle first `:a1` for `offset` and last `:a1` separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #438, where the Oracle visitor is raising an undefined method error when trying to calculate the limit for queries specifying both limit and offset.
Since this commit, ActiveModel now uses BindParams to pass limit and offset parameters to Arel, so it now isn't able to calculate the limit directly.
In this fix, when a BindParam object is passed to
visit_Arel_Nodes_SelectStatement, it now will use this binding instead of calculating the values. The previous behaviour remains when the offset expression is not a BindParam object.