Make union/except/intersect chainable #519
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118.
This is an updated and changed/simplified version of #320.
The idea remains the same (
SelectManager
returns a newSelectManager
on calls tounion/intersect/except
with, basically speaking, N-aryUnion/Intersect/Except
s taking place ofSelectCore
s insideSelectStatement
).TOP
related code forSelectStatement
was removed because it is basically anoop
operation and will require implement also noop method forUnion/.../...
classes to work herearel/lib/arel/select_manager.rb
Line 224 in df2b74b
Also, squashing braces in unions for MySQL was removed to allow applying limits and orders for individual queries. As stated in documentation:
But was introduced for SQLite, as it has troubles with parenthesized union subqueries and ordering + limits in them.
I'm also wondering, should all changed behavior be extensively deprecated or this PR can be merged in the next major version without any?