Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify postgres-client-version #60

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

cubasepp
Copy link
Contributor

To install a newer client version pass a variable.

https://www.postgresql.org/download/linux/ubuntu/\#apt

@cubasepp cubasepp marked this pull request as draft October 22, 2024 12:12
@cubasepp cubasepp force-pushed the postgres-client-version branch from a526ed6 to ea1f991 Compare October 22, 2024 12:19
@cubasepp cubasepp marked this pull request as ready for review October 22, 2024 12:20
@rafaelfranca rafaelfranca merged commit cb70847 into rails:main Nov 5, 2024
VERSION_EXISTS=$(apt-cache search --names-only postgresql-client-$POSTGRES_CLIENT_VERSION | wc -l)

if [ "$VERSION_EXISTS" -ge 1 ]; then
apt-get install --no-install-recommends -y postgresql-client-$POSTGRES_CLIENT_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why libpq-dev is not installed anymore? It's needed to build the pg gem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! Thank you for your fix. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants