Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Symbol explicitly to a JS String and add test #117

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Jul 19, 2022

A follow-up of #115, somehow I missed that Symbol should be treated the same as String.

The added test fails without the fix (because it ends up calling Ruby's String#slice and not JS's String.prototype.slice()), and passes with the fix.

cc FYI @bjfish

@byroot byroot merged commit e553b3f into rails:master Jul 19, 2022
@eregon eregon deleted the fix-symbol-conversion branch July 20, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants