Keep using URI RFC2396 parser #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default parser in URI 1.0.0 / Ruby 3.4 has been changed to RFC3986 [[1]]. This causes test failures such as: ~~~ ... snip ... Failure: GlobalIDTest#test_invalid_app_name [test/cases/global_id_test.rb:13]: ArgumentError expected but nothing was raised. rails test test/cases/global_id_test.rb:8 F ... snip ... ~~~ where underscores / ampersands are now allowed in host. Keep using URI RFC2396 parser for compatibility. Fixes rails#190 [1]: ruby/uri#107
voxik
changed the title
URI::RFC2396_PARSER parser
|
The Rails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default parser in URI 1.0.0 / Ruby 3.4 has been changed to RFC3986 [1]. This causes test failures such as:
where underscores / ampersands are now allowed in host. Keep using URI RFC2396 for compatibility.
Just FTR, I am not sure if this is the correct test. Maybe the failing test cases should be adjusted according to RFC3986 and underscores / ampersands allowed 🤷
Fixes #190