Run Railtie from the tests so that we can detect bugs inside Railtie #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatsuda
force-pushed
the
run_railtie_in_tests
branch
from
72ee525 to
5af3835
Compare
|
Confirmed that tests were failing with this patch https://github.com/rails/jbuilder/actions/runs/7401605179, then merged #552 and rebased, and all the tests are passing now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#552 seems like a valid fix. The
requirestatement seems to be requiring something that no longer exists. Then why isn't the CI failing? It should be because the Jbuilder Railtie is not executed during the tests.So, here's an attempt to make the CI run the Railtie. Let's see if the CI properly fails now...