New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import application JS as a module #178

Merged

dhh merged 1 commit into rails:main from afcapel:include-module

Jan 5, 2024

Commits on Nov 29, 2023

Import application JS as a module

Bun.js generates JS bundles in the ESM format and they need be imported with
the `type="module"` attribute. Otherwise the module varibles end up in the
global scope. See hotwired/turbo#1077

This commit updates the install generator to add the type="module" attribute
to the default `javascript_include_tag`.

`defer` is no longer needed, as JS modules are deferred by default.

Ref. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules#other_differences_between_modules_and_standard_scripts

This PR also updates the default config to ensure that all bundlers are
configured to output ESM bundles.

- bun only supports ESM at the moment https://bun.sh/docs/bundler#format
- esbuild is configured to output ESM with the --format=esm flag https://esbuild.github.io/api/#format-esm
- webpacker is configured to output ESM bundles with `output.chunkFormat` https://webpack.js.org/configuration/output/#outputchunkformat
- rollup is configured to output ESM bundles with `output.format` https://rollupjs.org/configuration-options/#output-format

afcapel committed Nov 29, 2023