Use a supported locale for localization #156
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for English based locales and fallback to I18n.default_locale if none is found. Uses :en if available.
sundling
force-pushed
the
i18n-available-locales
branch
from
afc3e47
to
bed5dd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #137 causes the exception
I18n::InvalidLocale: :en is not a valid localeto be raised if the application doesn't support theenlocale.It could be that the application uses
en-USinstead or maybe an English locale isn't available at all.This change fixes the exception by looking for English based locales and will fallback to I18n.default_locale if none is found.
Sorting the locales ensure that
enis used if it is available.