Redirect back after discarding a job #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @thiagobc, and sorry for the delay! I'be been busy with other stuff and haven't had time to look at this gem, but I'm catching up now. |
|
Ahh, this breaks the case of discarding a job from its individual page. It'd try to redirect to the job page, but it'll get a 404 error because the job is gone. I'll fix it. |
rosa
added a commit
that referenced
this pull request
Oct 31, 2024
This is a follow-up to #157, which redirected back after discarding instead of redirecting to the failed job page always, since you can discard a job from the scheduled jobs page as well. However, this doesn't work in the case of discarding a job from its individual page, because in that case we'd try to redirect to the job, and the job no longer exists, which results in a 404. With this change, we just redirect to wherever the status of the discarded job is.
rosa
added a commit
that referenced
this pull request
Oct 31, 2024
This is a follow-up to #157, which redirected back after discarding instead of redirecting to the failed job page always, since you can discard a job from the scheduled jobs page as well. However, this doesn't work in the case of discarding a job from its individual page, because in that case we'd try to redirect to the job, and the job no longer exists, which results in a 404. With this change, we just redirect to wherever the status of the discarded job is.
|
Hi @rosa! Sorry for breaking the pipeline, I missed running Anyway, thanks to you for the great project and for fixing my changes 🙏. (that was a smart fix by the way.) |
|
Oh, no worries at all, not your fault! I'm not sure why the tests didn't run automatically as part of your PR... they should have! You shouldn't need to remember that. Thanks a lot for your fix and your kind words! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discarding a job can currently be done from "Failed jobs" and "Scheduled jobs" pages, but, as a result, the user is always redirected to "Failed jobs" page.
This change will make the user be redirected back instead.