-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devcontainer: bump ruby version from 2-bullseye to 3-bullseye #218
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're already specifying 3-bullseye in devcontainer.json.
Updating the default args in the Dockerfiles is fine, but is this actually a bump?
I believe so, yes. When I build from
Whereas building from this branch gives:
This also fixes a bug in the Dockerfile where there is a zero incorrectly prepended to |
Looks like you had the previous 3-bullseye image and changing config resulted in pulling a current version. |
The leading 0- prefix is part of Microsoft's versioning scheme, btw: https://github.com/devcontainers/images/tree/main/src/ruby#using-this-image |
No, I purged Docker before testing this change. I used this:
Are you sure? I don't see that in the linked document. |
Ah, due to dropping the The prefix is for versioning the container itself, separate from the Ruby version: Take a look at other languages' containers and you'll see the same versioning scheme (and tags on the container repo). Tags for Ruby, for example. |
@jeremy Is there a change you are requesting, or is this just an observation? |
Bump Ruby version for the devcontainer from
2-bullseye
to3-bullseye
.To test:
Tests can then be run using: