Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer: bump ruby version from 2-bullseye to 3-bullseye #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jchilders
Copy link

Bump Ruby version for the devcontainer from 2-bullseye to 3-bullseye.

To test:

> devcontainer build --workspace-folder .
# ... no errors ...
> devcontainer up --workspace-folder .
> devcontainer exec --workspace-folder . -- ruby --version
ruby 3.3.5 (2024-09-03 revision ef084cc8f4) [aarch64-linux]

Tests can then be run using:

devcontainer exec --workspace-folder . -- bundle install
devcontainer exec --workspace-folder . -- rake

Copy link
Member

@jeremy jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're already specifying 3-bullseye in devcontainer.json.

Updating the default args in the Dockerfiles is fine, but is this actually a bump?

@jchilders
Copy link
Author

I believe so, yes. When I build from main I get the following:

> devcontainer exec --workspace-folder . -- ruby --version
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [aarch64-linux]

Whereas building from this branch gives:

devcontainer exec --workspace-folder . -- ruby --version
ruby 3.3.5 (2024-09-03 revision ef084cc8f4) [aarch64-linux]

This also fixes a bug in the Dockerfile where there is a zero incorrectly prepended to ${VARIANT}.

@jeremy
Copy link
Member

jeremy commented Nov 15, 2024

Looks like you had the previous 3-bullseye image and changing config resulted in pulling a current version.

@jeremy
Copy link
Member

jeremy commented Nov 15, 2024

The leading 0- prefix is part of Microsoft's versioning scheme, btw: https://github.com/devcontainers/images/tree/main/src/ruby#using-this-image

@jchilders
Copy link
Author

Looks like you had the previous 3-bullseye image and changing config resulted in pulling a current version.

No, I purged Docker before testing this change. I used this:

docker stop $(docker ps -aq) ; docker rm $(docker ps -aq) ; docker rmi $(docker images -q) -f ; docker volume rm $(docker volume ls -q) ; docker network rm $(docker network ls -q) ; docker builder prune -af ; docker system prune -af --volumes

The leading 0- prefix is part of Microsoft's versioning scheme, btw:

Are you sure? I don't see that in the linked document.

@jeremy
Copy link
Member

jeremy commented Nov 15, 2024

Ah, due to dropping the 0- prefix, then.

The prefix is for versioning the container itself, separate from the Ruby version:

Screenshot 2024-11-15 at 13 22 15

Take a look at other languages' containers and you'll see the same versioning scheme (and tags on the container repo). Tags for Ruby, for example.

@jchilders
Copy link
Author

@jeremy Is there a change you are requesting, or is this just an observation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants