Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Rails rubocop config, and drop support for ruby < 2.5 #151

Merged
merged 3 commits into from
Apr 11, 2023
Merged

dev: Rails rubocop config, and drop support for ruby < 2.5 #151

merged 3 commits into from
Apr 11, 2023

Conversation

flavorjones
Copy link
Member

In this PR:

  • import .rubocop.yml from rails/rails
  • move development dependencies from gemspec to Gemfile
  • set required_ruby_version to ">= 2.5.0"
  • correct all rubocop warnings

Note that Ruby 2.5 matches the oldest supported version of Rails (6.0/6.1).

@flavorjones
dep: set required_ruby_version to ">= 2.5.0"
ba95790 
this matches the oldest version of Rails (6.0/6.1)
@flavorjones
dep(style): move dev deps into Gemfile and add rubocop
45fa826 
import a copy of .rubocop.yml from rails/rails
@flavorjones
style(rubocop): correct all warnings
293903d
@flavorjones flavorjones requested a review from rafaelfranca April 3, 2023 04:15
@flavorjones flavorjones merged commit 0c567b4 into main Apr 11, 2023
@flavorjones flavorjones deleted the flavorjones-rubocop branch April 11, 2023 21:21
@flavorjones flavorjones mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfranca rafaelfranca rafaelfranca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flavorjones @rafaelfranca