Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with activerecord only (no rails) #13

Closed
wants to merge 2 commits into from

Conversation

schmurfy
Copy link

With the current version using this gem wihout rails is rather unintuitive and ugly:

require "rails/observers/activerecord/active_record"

Maybe this should be made easier or at least more intuitive.

@guilleiguaran
Copy link
Member

Can you add an alias for it and send a PR? This sounds good for me:

require "rails/observers/activerecord"

@rafaelfranca
Copy link
Member

Actually I don't know why they are with this name but these files should be rails/observers/active_record

@guilleiguaran
Copy link
Member

👍 rails/observers/activerecord/ needs to be renamed to rails/observers/active_record/ 😁

@schmurfy
Copy link
Author

Here you go, first commit is my request and the second if you want is the renaming of activerecord folder to active_record ;)

@schmurfy
Copy link
Author

so... any problem with this ?

@schmurfy
Copy link
Author

/ping @guilleiguaran @rafaelfranca

@schmurfy
Copy link
Author

schmurfy commented Oct 1, 2013

seriously any answer on this would be appreciated even if it is "go to hell" so at least I can close it.
is there even someone maintaining this "project" ?

@rafaelfranca
Copy link
Member

sorry for the delay. I'll take a look on it.

I'm maintaining this project, but I'm also maintaining all the projects in the Rails organization, so things can take a while.

@nanernunes
Copy link

I'm really expecting to use something better than
require 'rails/observers/activerecord/active_record'

Any news about this change?

@schmurfy
Copy link
Author

schmurfy commented Apr 8, 2015

I found this issue while doing a cleanup on my repositories list, so... shall I remove my fork or is there any hope this can get merged in a foreseeable future ? (like really really soon)
I don't care what happen to this project, the pull request was not even for me as I don't use it it was to help a friend trying to figure out how to hell to use this outside rails and as an extension anyone who wants to do the same.

I surely can fix the conflict but I won't bother unless there is 100% chances it gets in.

@rafaelfranca
Copy link
Member

Keep it open please. I'll take a look. Sorry for the delay

On Wed, Apr 8, 2015, 10:55 Julien Ammous notifications@github.com wrote:

I found this issue while doing a cleanup on my repositories list, so...
shall I remove my fork or is there any hope this can get merged in a
foreseeable future ? (like really really soon)
I don't care what happen to this project, the pull request was not even
for me as I don't use it it was to help a friend trying to figure out how
to hell to use this outside rails and as an extension anyone who wants to
do the same.

I surely can fix the conflict but I won't bother unless there is 100%
chances it gets in.


Reply to this email directly or view it on GitHub
#13 (comment).

@mvastola mvastola mentioned this pull request Jul 17, 2017
@schmurfy schmurfy closed this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants