Redesign banner and mobile menu bar #280
Conversation
|
Thanks for working on this @jonathanhefner . I think overall this is an improvement. It seems the margins aren't correct for the mobile page: |
Yes, the problem goes back at least as far as when #227 was submitted: https://deploy-preview-227--sdoc.netlify.app/files/actionpack/lib/action_controller/base_rb. (The preview for #226 and earlier have expired, so I can't check those.) I am working on a PR that updates margins, so I will take care of it. 👍 |
This commit redesigns the banner that was formerly displayed at the top of each page. The banner and the logo are now integrated, and they also serve as the mobile menu bar. The `menu.svg` and `close.svg` files are from [Feather icons][feather] v4.29.0, and are [licensed under the MIT license][license]. [feather]: https://feathericons.com/ [license]: https://github.com/feathericons/feather/blob/v4.29.0/LICENSE
jonathanhefner
force-pushed
the
banner-redesign
branch
from
9749333 to
c17deff
Compare
In rails#223, we began generating default `<h1>` headings for modules. However, these headings were only generated for modules that had a description. If a module had no comment to begin with, it would not get a generated heading. Furthermore, since rails#280, each module's full name has been prominently displayed at the top of its page. These names are visually redundant with generated headings, which also use the full name. To unify the design and ensure that all modules have an `<h1>`, this commit converts each module's full name into an `<h1>` heading inside an `<hgroup>`, and uses postprocessing to pull any comment-based `<h1>` into the `<hgroup>`. This commit also renames the "Included Modules" section to "Inherits From", and moves any listed base class from the top of the page to the top of that section. This change focuses the `<h1>`, both visually and from an SEO perspective.
This commit redesigns the banner that was formerly displayed at the top of each page. The banner and the logo are now integrated, and they also serve as the mobile menu bar.
The
menu.svgandclose.svgfiles are from Feather icons v4.29.0, and are licensed under the MIT license.