Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify installer #5

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

fractaledmind
Copy link
Contributor

This matches the structure that Solid Queue now uses (after rails/solid_queue#321) and Solid Cache now uses (after rails/solid_cache#202)

Copy link
Collaborator

@npezza93 npezza93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few text tweaks then this is good to go! Thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fractaledmind and others added 3 commits September 10, 2024 10:46
Co-authored-by: Nick Pezza <pezza@hey.com>
Co-authored-by: Nick Pezza <pezza@hey.com>
@fractaledmind
Copy link
Contributor Author

@npezza93: Thanks. Updated

@npezza93 npezza93 merged commit a76c64e into rails:main Sep 10, 2024
2 checks passed
If you want to install to a different database you can pass an env variable.
```bash
$ DATABASE=cable bin/rails generate solid_cable:install
This will create the `db/cable_schema.rb` file.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cable_schema.rb ends up in the app's root folder instead of the db folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. That's not good.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 1.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants