Skip to content

Commit

Permalink
Remove redundant run methods in SolidQueue::Processes
Browse files Browse the repository at this point in the history
This commit removes one of the redundant `run` methods in `SolidQueue::Processes`

Here are the warning messages appeared at Rails Nightly CI:
https://buildkite.com/rails/rails-nightly/builds/1091#019244bc-9d36-476d-8924-5e2bea4cb728/1173-1176
```
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:52: warning: method redefined; discarding old run
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:44: warning: previous definition of run was here
```
  • Loading branch information
yahonda committed Oct 1, 2024
1 parent 29b1847 commit e7198f4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/solid_queue/processes/runnable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ def boot
end
end

def run
raise NotImplementedError
end

def shutting_down?
stopped? || (running_as_fork? && supervisor_went_away?) || finished? || !registered?
end
Expand Down

0 comments on commit e7198f4

Please sign in to comment.