-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bin/jobs
binstub to run the supervisor more easily and remove the async
mode
#308
Conversation
bin/jobs
binstub to run the supervisor more easilybin/jobs
binstub to run the supervisor more easily and remove the async
mode
…on install We never want to skip the migrations but we might want to skip setting the adapter if we're moving from another Active Job backend. Also, add a `database` option to select a different DB from the main one when copying the migrations.
Still running all its supervised processes as threads, but now can be run separately from Puma.
And rename sidecar to standalone, inverting the meaning.
And a nicer Cli class to use over in the binstub with better args instead of environment variables.
It's been short-lived ^_^U
Is the new |
Great question! It's mostly equivalent, witih a few differences. It allows passing a I'd say |
@rosa Thanks for explaining! |
This also fixes that the supervisor couldn't be started inThis completely removes theasync
mode unless using the Puma pluginasync
mode, as we've decided to make this straightforward and simpler and offer just a single way to run it.This PR also includes other minor issues in the installation: avoiding overwriting an existing
config/solid_queue.yml
file and accepting a--database
parameter to specify a separate Solid Queue DB to install the migrations. The newbin/jobs
binstub is copied over as part of the installation.