Allow to configure boot and connect timeout #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshenny
reviewed
Apr 16, 2024
jenshenny
reviewed
Apr 16, 2024
lib/spring/configuration.rb
Outdated
Comment on lines
8
to
12
| attr_accessor :connect_timeout | ||
| @connect_timeout = 5 | ||
|
|
||
| attr_accessor :boot_timeout | ||
| @boot_timeout = 20 |
There was a problem hiding this comment.
These instance variables aren't being correctly set currently (the accessors return nil)
`+': can't convert NilClass into an exact number (TypeError)
It works if you place them outside of the class methods
module Spring
@connect_timeout = 5
@boot_timeout = 20
class << self
There was a problem hiding this comment.
Yeah, sorry, just did a quick patch without testing before leaving my desk. I think it should be good now.
byroot
force-pushed
the
configurable-timeouts
branch
from
2087ee5
to
7d06dec
Compare
The hardcoded values might not be enough for all applications.
byroot
force-pushed
the
configurable-timeouts
branch
from
7d06dec
to
d73d1db
Compare
|
I'm getting a lot of this with spring 4.2.0: I'm hoping this PR might allow me to fix that by adjusting the timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardcoded values might not be enough for all applications.